Conversation
mjohnson12
left a comment
There was a problem hiding this comment.
Will this break register? I would be surprised if all Workers Outputs were Sendable.
I ran a local test a couple of weeks ago with no issues.
|
|
Integration passed 👍 |
jamieQ
left a comment
There was a problem hiding this comment.
before we proceed further with this effort, i think we should have a bit of discussion around the motivation and future direction of this type of change to better expose things to the concurrency system. two thoughts that come to mind:
- imposing a
Sendableconformance on a type is a fairly substantial ask in general since it's asserting that type must be able to be passed across arbitrary isolation domains. is this the right approach? - is this potentially a source-break for existing clients, so would necessitate a major semver bump? (granted register is probably the primary one)
That makes sense. For background, this came up because of a warning currently in
This is probably the right approach, given what
Yes it does have the potential to break clients if their |
Adds
Sendableconformance as a constraint onWorkflow.Output.Checklist