Merged
Conversation
Collaborator
zach-klippenstein
commented
Dec 9, 2018
zach-klippenstein
commented
- 9c879cd Fix switchMapState isn't actually a switchMap, it's a concatMap #69 by correctly implementing switchMapState operator.
- e304784 Fix Result of mapResult operator doesn't propagate cancellation upstream #71 by cancelling upstream workflow when mapResult workflow is cancelled.
- 1876788 Move the workflow operators into their own file and write unit tests.
rjrjr
approved these changes
Dec 10, 2018
| import kotlin.coroutines.experimental.CoroutineContext | ||
|
|
||
| /** | ||
| * [CoroutineContext] used by [Workflow] operators below. |
Contributor
There was a problem hiding this comment.
Could explain why you chose Unconfined. (Follow up for nits is fine w/me.)
| upstreamChannel.consume { | ||
| whileSelect { | ||
| upstreamChannel.onReceiveOrNull { upstreamState -> | ||
| if (upstreamState == null) { |
Contributor
There was a problem hiding this comment.
I wonder if both of these would be more readable flipped and converted to use ?.let / ?:.
Collaborator
Author
There was a problem hiding this comment.
That feels like code golf to me. let improves readability when the nullable value is being transformed, in this case it's not, it's being used as a sentinel for a completely different signal (channel close). This isn't ideal obviously and there's an open issue to make a more explicit receive call that doesn't use null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.