Skip to content

Solving bug of missing labels#56

Merged
sinnec merged 3 commits intomainfrom
47-this-line-breaks-when-few-data-is-passed-with-not-enough-variations
Dec 8, 2022
Merged

Solving bug of missing labels#56
sinnec merged 3 commits intomainfrom
47-this-line-breaks-when-few-data-is-passed-with-not-enough-variations

Conversation

@NickNtamp
Copy link
Copy Markdown
Contributor

With this PR we are adding the labels as a parameter in evaluation pipelines. Also I added an edge case unit test per pipeline. This solves the issue but there are some open questions and pending work:

  • @sinnec can you please connect this with the pipeline by feeding the possible labels, as we discussed. Don't forget that we are asking for the values of client's input.
  • @momegas we observed along with @sinnec that the labels are optional in models.py under schema folder. This should be mandatory. Also there is a question here, what will happen if the client insert the labels in wrong way? Maybe it is better in our next iteration to find the labels by our own and don't asking them by the client at all. It is pretty easy as we just seeking for the unique values of the target column of training set.

Comment thread src/cron_tasks/monitoring_metrics.py
@sinnec sinnec merged commit 0973354 into main Dec 8, 2022
@gcharis gcharis deleted the 47-this-line-breaks-when-few-data-is-passed-with-not-enough-variations branch December 20, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This line breaks when few data is passed with not enough variations

3 participants