Skip to content

Add configValidation to DattoRMM plugin#46

Merged
TimWheeler-SQUP merged 2 commits into
mainfrom
work/tw/DattoRMM-configValidation
Jun 1, 2026
Merged

Add configValidation to DattoRMM plugin#46
TimWheeler-SQUP merged 2 commits into
mainfrom
work/tw/DattoRMM-configValidation

Conversation

@TimWheeler-SQUP
Copy link
Copy Markdown
Contributor

📋 Summary

Adds a configValidation.json to the DattoRMM plugin so users get a connection test step during plugin setup. It validates the Base URL, API Key, and API Secret by exercising the existing importSites data stream (calls api/v2/account/sites).


🔗 Related issue(s)


🧩 Plugin details

  • Plugin name: Datto RMM
  • Type of change:
    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe): Adds configValidation step

⚠️ Breaking changes

Does this PR introduce any breaking changes?

  • No
  • Yes (please describe):

📚 Documentation

  • No documentation changes needed

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

Adds a connection test step so users get immediate feedback on whether
their Base URL, API Key, and API Secret are valid during plugin setup.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@TimWheeler-SQUP TimWheeler-SQUP requested review from a team and clarkd May 11, 2026 19:36
Copy link
Copy Markdown
Member

@clarkd clarkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude should flag this too but you'll need to bump the version number - otherwise looks good!

@clarkd
Copy link
Copy Markdown
Member

clarkd commented May 12, 2026

@claude review this

Comment thread plugins/DattoRMM/v1/configValidation.json
@shaswot77 shaswot77 added the enhancement New feature or request label May 15, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/DattoRMM/v1

📋 Results

Step Status
Validation ✅ Passed
Deployment 🚀 Deployed

🔍 Validation Details

datto-rmm
{
  "valid": true,
  "pluginName": "datto-rmm",
  "pluginType": "cloud",
  "summary": {
    "Data Streams": 4,
    "Import Definitions": 1,
    "UI Configuration": true,
    "Has Icon": true,
    "Has Default Content": true,
    "Config Validation": true,
    "Custom Types": true
  }
}

@TimWheeler-SQUP TimWheeler-SQUP requested a review from clarkd June 1, 2026 14:07
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump has been applied addressing my previous feedback — straightforward addition of a configValidation step.

Extended reasoning...

Overview

This PR adds a single configValidation.json file to the DattoRMM plugin and bumps the version in metadata.json from 1.0.1 to 1.0.2. The validation step reuses the existing importSites data stream to test connectivity during plugin setup. Total diff is ~12 lines.

Security risks

None. No credentials, secrets, or auth changes. The configValidation uses an existing data stream that already handles auth via the established OAuth2 flow defined in metadata.json. No new endpoints or attack surface.

Level of scrutiny

Low. This is exactly the kind of mechanical, pattern-following change that doesn't need human review: a small JSON file that follows the established configValidation pattern used by other plugins in the repo, plus a patch-level version bump. The schema is correct (steps array with displayName, dataStream, success, error, required fields).

Other factors

My previous review on 2026-05-12 flagged the missing version bump. The author has now addressed that feedback (1.0.1 → 1.0.2). CI validation passed (Config Validation: true in the bot summary). No outstanding reviewer comments remain unaddressed.

@TimWheeler-SQUP TimWheeler-SQUP merged commit 4f07e0e into main Jun 1, 2026
2 checks passed
@TimWheeler-SQUP TimWheeler-SQUP deleted the work/tw/DattoRMM-configValidation branch June 1, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin: DattoRMM

Development

Successfully merging this pull request may close these issues.

3 participants