Fix maintenance PR creation#33
Merged
Merged
Conversation
The `--quiet` parameter removes patch from `git diff` output rendering the line count useless as a trigger to create PRs. Instead use `--shortstat` which produces nothing when there is no difference the the given branches, and a line of statistics if there are differences.
squid-anubis
added
M-failed-description
kinkie
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--quietparameter removes patch fromgit diffoutput rendering the line count useless as a trigger
to commit changes.
Instead use
--shortstatwhich produces nothing whenthere is no difference the the given branches, and a
line of statistics if there are differences.
Recent
ghtool produce a message when no PRs exist.Causing this script to wrongly decide that no PR is needed.
Check for that output and revert the line count test to check
for that empty case at trigger.