Default to full gdb backtraces#21
Merged
rousskov merged 2 commits intosquid-cache:mainfrom Feb 16, 2024
Merged
Conversation
Receiving a dump of local variables often reduces the number of requests for more information in bug reports and speeds up triage. The downsides (i.e. more output, slightly higher risk of exposing sensitive information, and hypothetical lack of support in very old gdb) are not significant enough to preserve the old "less info" default. AFAICT, gdb supports `backtrace full` since 1998 commit 65b07dd (at least). Since 2019, gdb prefers `backtrace -full` to `backtrace full`, but we are not upgrading yet to accommodate older/more environments. Other debuggers may not support "full", but our instructions are already gdb-specific, and most folks folks can adapt them as needed. Also do not distract the reader with an out-of-scope explanation on how gdb commands may be abbreviated (e.g., "bt" instead of "backtrace").
rousskov
commented
Feb 14, 2024
yadij
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Receiving a dump of local variables often reduces the number of requests
for more information in bug reports and speeds up triage. The downsides
(i.e. more output, slightly higher risk of exposing sensitive
information, and hypothetical lack of support in very old gdb) are not
significant enough to preserve the old "less info" default.
AFAICT, gdb supports
backtrace fullsince 1998 commit 65b07dd (atleast). Since 2019, gdb prefers
backtrace -fulltobacktrace full,but we are not upgrading yet to accommodate older/more environments.
Other debuggers may not support "full", but our instructions are already
gdb-specific, and most folks folks can adapt them as needed.
Also do not distract the reader with an out-of-scope explanation on how
gdb commands may be abbreviated (e.g., "bt" instead of "backtrace").