ext_time_quota_acl: remove -l option #1872
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug logging to own file does not work well when there parallel helpers, which could clobber each other's output. It's better to log through squid and find the output in cache.log . Remove the -l option in preparation for switching ext_time_quota_acl's log system to use Squid's debug API
Contributor
Author
|
This is a stepping stone for pr #1847 which will hopefully immediately follow |
rousskov
reviewed
Jul 24, 2024
rousskov
added
the
S-waiting-for-author
yadij
previously approved these changes
Jul 26, 2024
kinkie
added
S-waiting-for-reviewer
rousskov
requested changes
Jul 26, 2024
rousskov
added
S-waiting-for-author
yadij
previously approved these changes
Jul 26, 2024
yadij
removed
the
S-waiting-for-author
rousskov
added
S-waiting-for-author
kinkie
added
S-waiting-for-reviewer
rousskov
added
S-waiting-for-author
kinkie
added
the
M-cleared-for-merge
Contributor
Author
|
All outstanding requests for change are addressed. Waiting for approval or slow burner timeout, clearing for merge in the meanwhile |
kinkie
added
S-could-use-an-approval
rousskov
added
S-waiting-for-PR
squid-anubis
pushed a commit
that referenced
this pull request
Aug 6, 2024
Supporting logging to a file complicates upgrading helper code to use debugs() because DebugFile code calls commSetCloseOnExec(), and our comm/libminimal does not currently provide a functioning implementation for that API: The existing implementation is an unconditional assert. To save development time while upgrading helpers, we are dropping this feature. It can probably be emulated using shell redirection tricks.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
kinkie
added a commit
to kinkie/squid
that referenced
this pull request
Oct 2, 2024
Supporting logging to a file complicates upgrading helper code to use debugs() because DebugFile code calls commSetCloseOnExec(), and our comm/libminimal does not currently provide a functioning implementation for that API: The existing implementation is an unconditional assert. To save development time while upgrading helpers, we are dropping this feature. It can probably be emulated using shell redirection tricks. ---- Backport of PR squid-cache#1872
kinkie
removed
backport-to-v6
S-could-use-an-approval
Contributor
Author
|
Hand-backporting in PR #1909 |
kinkie
added a commit
that referenced
this pull request
Oct 11, 2024
Supporting logging to a file complicates upgrading helper code to use debugs() because DebugFile code calls commSetCloseOnExec(), and our comm/libminimal does not currently provide a functioning implementation for that API: The existing implementation is an unconditional assert. To save development time while upgrading helpers, we are dropping this feature. It can probably be emulated using shell redirection tricks. ---- Backport of PR #1872
kinkie
added a commit
to kinkie/squid
that referenced
this pull request
Oct 12, 2024
Supporting logging to a file complicates upgrading helper code to use debugs() because DebugFile code calls commSetCloseOnExec(), and our comm/libminimal does not currently provide a functioning implementation for that API: The existing implementation is an unconditional assert. To save development time while upgrading helpers, we are dropping this feature. It can probably be emulated using shell redirection tricks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting logging to a file complicates upgrading helper code to use
debugs() because DebugFile code calls commSetCloseOnExec(), and our
comm/libminimal does not currently provide a functioning implementation
for that API: The existing implementation is an unconditional assert.
To save development time while upgrading helpers, we are dropping this
feature. It can probably be emulated using shell redirection tricks.