Skip to content

Remove ext_lm_group_acl helper #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kinkie wants to merge 9 commits into from
Closed

Remove ext_lm_group_acl helper #2011

kinkie wants to merge 9 commits into from
+13 −874

Conversation

@kinkie
Copy link
Contributor

@kinkie kinkie commented Mar 2, 2025

Lan Manager (LM) is an obsolete variant of the SMB protocol.
No product on the market has supported it for several years now,
in favour of NTLMv1 , NTLMv2 and Kerberos.

@kinkie
Copy link
Contributor Author

kinkie commented Mar 2, 2025

One of three. Supersedes PR #2009

rousskov
rousskov reviewed Mar 2, 2025
View reviewed changes
@kinkie kinkie added S-could-use-an-approval An approval may speed this PR merger (but is not required) M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Mar 3, 2025
yadij
yadij requested changes Mar 3, 2025
View reviewed changes
@yadij yadij added S-waiting-for-author author action is expected (and usually required) and removed S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Mar 3, 2025
@kinkie kinkie requested a review from yadij March 3, 2025 09:15
@kinkie kinkie added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Mar 3, 2025
@yadij yadij added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Mar 3, 2025
@kinkie kinkie added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box S-waiting-for-more-reviewers needs a reviewer and/or a second opinion and removed S-waiting-for-author author action is expected (and usually required) labels Mar 3, 2025
yadij
yadij previously approved these changes Mar 3, 2025
View reviewed changes
@yadij yadij added feature maintainer needs documentation updates for merge and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Mar 3, 2025
@yadij yadij requested a review from rousskov March 3, 2025 14:35
rousskov
rousskov reviewed Mar 3, 2025
View reviewed changes
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-more-reviewers needs a reviewer and/or a second opinion labels Mar 3, 2025
@kinkie @rousskov
Apply suggestions from code review
9047ec4 
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
rousskov
rousskov reviewed Mar 3, 2025
View reviewed changes
yadij
yadij previously approved these changes Mar 4, 2025
View reviewed changes
@yadij

This comment was marked as resolved.

Sign in to view
@yadij
Update release-8.sgml.in
b260c72 
trying editor again
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) and removed S-waiting-for-author author action is expected (and usually required) labels Mar 4, 2025
squid-anubis pushed a commit that referenced this pull request Mar 4, 2025
@kinkie @squid-anubis
Remove ext_lm_group_acl helper (#2011)
56d17b9 
Lan Manager (LM) is an obsolete variant of the SMB protocol.
No product on the market has supported it for several years now,
in favour of NTLMv1 , NTLMv2 and Kerberos.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-other https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Mar 4, 2025
@rousskov rousskov removed S-could-use-an-approval An approval may speed this PR merger (but is not required) M-failed-staging-other https://github.com/measurement-factory/anubis#pull-request-labels labels Mar 4, 2025
squid-anubis pushed a commit that referenced this pull request Mar 4, 2025
@kinkie @squid-anubis
Remove ext_lm_group_acl helper (#2011)
4b7b6df 
Lan Manager (LM) is an obsolete variant of the SMB protocol.
No product on the market has supported it for several years now,
in favour of NTLMv1 , NTLMv2 and Kerberos.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Mar 4, 2025
@rousskov rousskov added the S-waiting-for-QA QA team action is needed (and usually required) label Mar 5, 2025
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Mar 5, 2025
@rousskov rousskov removed the S-waiting-for-QA QA team action is needed (and usually required) label Mar 5, 2025
@kinkie kinkie added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed M-merged https://github.com/measurement-factory/anubis#pull-request-labels labels Mar 6, 2025
kinkie added a commit to kinkie/squid that referenced this pull request Mar 26, 2025
@kinkie
Remove ext_lm_group_acl helper (squid-cache#2011)
29e4932 
Lan Manager (LM) is an obsolete variant of the SMB protocol.
No product on the market has supported it for several years now,
in favour of NTLMv1 , NTLMv2 and Kerberos.
@rousskov rousskov removed the M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels label Sep 9, 2025
@rousskov rousskov mentioned this pull request Sep 30, 2025
Closed
@kinkie kinkie deleted the remove-lanman-01 branch January 5, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousskov rousskov rousskov left review comments

@yadij yadij yadij approved these changes

Assignees

No one assigned

Labels

feature maintainer needs documentation updates for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kinkie @yadij @rousskov @squid-anubis