Fix scripts/update-contributors.pl CONTRIBUTORS screening #2125
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible unintended interpolation of @users in string
Bareword "true" not allowed
Bareword "false" not allowed
Execution of ... aborted due to compilation errors
Recent commit daa76f4 broke scripts/update-contributors.pl syntax (see
error messages quoted above) and lower-case comparison logic,
effectively disabling CONTRIBUTORS checks.
An `if` statement with a false condition and without an `else` clause always succeeds, setting `$?` to 0 (including cases when the condition command itself fails to execute).
Contributor
Author
|
I did not have a chance to review #2109. The problem was discovered by @eduard-bagdasaryan while working on an unrelated improvement. I am asking him to review this PR. Some of the problems fixed in this PR can be seen in recent PRs: CI logs show errors despite overall successful source-maintenance checks. |
rousskov
added
the
S-waiting-for-reviewer
yadij
approved these changes
Jul 21, 2025
Contributor
|
LGTM |
squid-anubis
pushed a commit
that referenced
this pull request
Jul 21, 2025
Possible unintended interpolation of @users in string
Bareword "true" not allowed
Bareword "false" not allowed
Execution of ... aborted due to compilation errors
Recent commit daa76f4 broke scripts/update-contributors.pl syntax (see
error messages quoted above) and its lower-case comparison logic,
effectively disabling CONTRIBUTORS checks.
Also do not hide update-contributors.pl execution failures. Buggy
failure detection contributed to the above problems ignored by CI tests.
squid-anubis
added
the
M-waiting-staging-checks
| result=$? | ||
| ./scripts/update-contributors.pl --quiet < authors.tmp > CONTRIBUTORS.new || return | ||
| updateIfChanged CONTRIBUTORS CONTRIBUTORS.new \ | ||
| "A human PR description should match: $vettedCommitPhraseRegex" || return |
Contributor
There was a problem hiding this comment.
Don't we need to delete authors.tmp if updateIfChanged() fails?
Contributor
Author
There was a problem hiding this comment.
Don't we need to delete
authors.tmpifupdateIfChanged()fails?
In the ideal world, probably yes. In that ideal world, such cleanup would be controlled by a configuration option that would allow folks to leave temporary files for failure triage.
In reality, the benefits from removing authors.tmp when git, update-contributors.pl, or updateIfChanged() fails are not worth the effort required to guarantee and control that removal. And the harm is relatively small because these temporary files are not going to accumulate across failures.
squid-anubis
added
M-passed-staging-checks
rousskov
added
M-cleared-for-merge
squid-anubis
added
M-merged
yadij
added
the
backport-to-v7
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Jan 17, 2026
…e#2125) Possible unintended interpolation of @users in string Bareword "true" not allowed Bareword "false" not allowed Execution of ... aborted due to compilation errors Recent commit daa76f4 broke scripts/update-contributors.pl syntax (see error messages quoted above) and its lower-case comparison logic, effectively disabling CONTRIBUTORS checks. Also do not hide update-contributors.pl execution failures. Buggy failure detection contributed to the above problems ignored by CI tests.
squidadm
removed
the
backport-to-v7
Collaborator
|
queued for backport to v7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent commit daa76f4 broke scripts/update-contributors.pl syntax (see
error messages quoted above) and its lower-case comparison logic,
effectively disabling CONTRIBUTORS checks.
Also do not hide update-contributors.pl execution failures. Buggy
failure detection contributed to the above problems ignored by CI tests.