CI: Collect logs of failed unit tests #2348
Closed
eduard-bagdasaryan wants to merge 6 commits intosquid-cache:masterfrom
Closed
CI: Collect logs of failed unit tests #2348eduard-bagdasaryan wants to merge 6 commits intosquid-cache:masterfrom
eduard-bagdasaryan wants to merge 6 commits intosquid-cache:masterfrom
Conversation
When a unit test fails during CI checks, the corresponding GitHub
Actions reports and collected btlayer-*.log files do not contain
any failure details, for example:
FAIL: tests/testRock
# FAIL: 1
Critical details are missing:
stub time| FATAL: Ipc::Mem::Segment::create failed to
shm_open(/squid-0-tr_rebuild_versions.shm): (63) File name too long
Now GitHub Actions reports collect all log files, including
unit test logs.
The downloaded log archive did not contain unit test logs. Added temporary logging to check this.
To check the theory that the downloaded log archive contains unit test logs only if some of them fail.
yadij
reviewed
Jan 10, 2026
yadij
approved these changes
Jan 10, 2026
rousskov
approved these changes
Jan 10, 2026
yadij
added
M-cleared-for-merge
kinkie
approved these changes
Jan 11, 2026
squid-anubis
pushed a commit
that referenced
this pull request
Jan 11, 2026
When a unit test fails during CI checks, the corresponding GitHub
Actions reports and collected btlayer-*.log files do not contain
any failure details. For example, we see
FAIL: tests/testRock
# FAIL: 1
but are missing critical details like
stub time| FATAL: Ipc::Mem::Segment::create failed to
shm_open(/squid-0-tr_rebuild_versions.shm): (63) File name too long
Now, GitHub Actions collect all log files, including unit test logs. For
the `ubuntu-24.04,gcc,default` build target, adding more logs increases
artifacts zip archive size by about 100 KB (from ~200KB to ~300KB).
If `test-builds.sh` succeeds, there are no unit test logs to collect
because all unit test logs are erased when `make distcheck` (initiated
by `test-builds.sh`) reaches its `make distclean` step. If a unit test
fails, then that cleaning step is not reached, (successful and failed)
unit test logs are preserved and are now added to CI artifacts.
squid-anubis
added
M-waiting-staging-checks
rousskov
removed
S-could-use-an-approval
squid-anubis
pushed a commit
that referenced
this pull request
Jan 13, 2026
When a unit test fails during CI checks, the corresponding GitHub
Actions reports and collected btlayer-*.log files do not contain
any failure details. For example, we see
FAIL: tests/testRock
# FAIL: 1
but are missing critical details like
stub time| FATAL: Ipc::Mem::Segment::create failed to
shm_open(/squid-0-tr_rebuild_versions.shm): (63) File name too long
Now, GitHub Actions collect all log files, including unit test logs. For
the `ubuntu-24.04,gcc,default` build target, adding more logs increases
artifacts zip archive size by about 100 KB (from ~200KB to ~300KB).
If `test-builds.sh` succeeds, there are no unit test logs to collect
because all unit test logs are erased when `make distcheck` (initiated
by `test-builds.sh`) reaches its `make distclean` step. If a unit test
fails, then that cleaning step is not reached, (successful and failed)
unit test logs are preserved and are now added to CI artifacts.
squid-anubis
added
M-waiting-staging-checks
squid-anubis
added
M-merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a unit test fails during CI checks, the corresponding GitHub
Actions reports and collected btlayer-*.log files do not contain
any failure details. For example, we see
but are missing critical details like
Now, GitHub Actions collect all log files, including unit test logs. For
the
ubuntu-24.04,gcc,defaultbuild target, adding more logs increasesartifacts zip archive size by about 100 KB (from ~200KB to ~300KB).
If
test-builds.shsucceeds, there are no unit test logs to collectbecause all unit test logs are erased when
make distcheck(initiatedby
test-builds.sh) reaches itsmake distcleanstep. If a unit testfails, then that cleaning step is not reached, (successful and failed)
unit test logs are preserved and are now added to CI artifacts.