Maintenance: minor COPYING/CREDITS updates#2383
Maintenance: minor COPYING/CREDITS updates#2383yadij wants to merge 2 commits intosquid-cache:masterfrom
Conversation
The official GPLv2 document no longer lists a street address for the Free Software Foundation. Pull in the newest document to get an up to date copy of the Licence.
Latest version of this library has a slighty different blurb.
yadij
added
M-cleared-for-merge
rousskov
changed the title
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
I have adjusted PR title to lessen the implication that we are updating something that affects (copy) rights.
| 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
|
|
||
| License along with GNU Libltdl. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
There was a problem hiding this comment.
Where did the set of paragraphs in this libltdl/: section come from, exactly? I do not see a matching set of paragraphs in libltdl sources that get generated on my test box. I see similar paragraph sets, and some paragraphs match exactly, but I do not not a particular set proposed in this PR. What specific libltdl version (if any) generates the exact proposed set?
FWIW, official variations of this license do not contain a template that would produce the above paragraphs either:
- https://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt template does not have "version 2 of the License" text used in the beginning of this section
- https://www.gnu.org/licenses/old-licenses/lgpl-2.0.txt template does not make "this library" a template parameter (substituted with "GNU Libltdl" in Squid text).
If we are updating this text, let's exactly match either what some generated libltdl sources contain (and mention what specific libltdl source file we used in the PR description) or, if really needed, faithfully instantiate the official lgpl-2.0.txt template.
There was a problem hiding this comment.
This comes from libltdl/ltdl.h in libtool-2.5.3 (or later). Upstream commit ec703fac9e4a21d2cb1404d19353204499ad9f30.
There was a problem hiding this comment.
The LGPL that applies to the imported libltdl is shipped as libldtl/COPYING.LIB if we need it.
There was a problem hiding this comment.
This comes from
libltdl/ltdl.hinlibtool-2.5.3(or later). Upstream commit ec703fac9e4a21d2cb1404d19353204499ad9f30.
Thank you for updating PR description accordingly.
The LGPL that applies to the imported
libltdlis shipped aslibldtl/COPYING.LIBif we need it.
That file contains a different/successor/v2.1 variation/version of LGPL. Libltdl sources exclude it since 2011 -- it gets copied from gnulib during bootstrapping AFAICT. The remaining discrepancy between our CREDITS and some libltdl files is unfortunate, but I think it is best to ignore that minor problem (until libltdl files themselves become consistent, at least).
rousskov
added
S-waiting-for-author
yadij
added
M-cleared-for-merge
| 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||
|
|
||
| License along with GNU Libltdl. If not, see <https://www.gnu.org/licenses/>. | ||
|
|
There was a problem hiding this comment.
This comes from
libltdl/ltdl.hinlibtool-2.5.3(or later). Upstream commit ec703fac9e4a21d2cb1404d19353204499ad9f30.
Thank you for updating PR description accordingly.
The LGPL that applies to the imported
libltdlis shipped aslibldtl/COPYING.LIBif we need it.
That file contains a different/successor/v2.1 variation/version of LGPL. Libltdl sources exclude it since 2011 -- it gets copied from gnulib during bootstrapping AFAICT. The remaining discrepancy between our CREDITS and some libltdl files is unfortunate, but I think it is best to ignore that minor problem (until libltdl files themselves become consistent, at least).
rousskov
removed
the
S-could-use-an-approval
The current official GPLv2 text has been modified to remove the FSF street address. Bring our GPL copy up to date with the official GPLv2 license document. Also, libltdl license has similar changes. Update our CREDITS file to match the v2.5.3+ libltdl/ldtl.h import. There are no legal implications from this change.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
The current official GPLv2 text has been modified to remove the FSF street address. Bring our GPL copy up to date with the official GPLv2 license document. Also, libltdl license has similar changes. Update our CREDITS file to match the v2.5.3+ libltdl/ldtl.h import. There are no legal implications from this change.
squidadm
removed
the
backport-to-v7
|
queued for backport to v7 |
5 participants
The current official GPLv2 text has been modified to
remove the FSF street address. Bring our GPL copy
up to date with the official GPLv2 license document.
Also, libltdl license has similar changes. Update our
CREDITS file to match the v2.5.3+ libltdl/ldtl.h import.
There are no legal implications from this change.