Improve parsing of certain FTP directory listing formats#2408
Closed
rousskov wants to merge 1 commit intosquid-cache:masterfrom
Closed
Improve parsing of certain FTP directory listing formats#2408rousskov wants to merge 1 commit intosquid-cache:masterfrom
rousskov wants to merge 1 commit intosquid-cache:masterfrom
Conversation
This surgical fix restricts parsing to the input buffer when the listing entry date in "TypeA" or "TypeB" formats is not followed by a filename. It does not improve rendering of listings with missing filenames or the overall quality of FTP listing parsing code. C strchr() always returns a non-nil pointer when given a NUL character, so its callers must be careful not to supply a NUL character if a "natural" one-of-the-regular-c-string-characters membership test is required. The bug was probably introduced in 1997 commit 3fdadc7 and then duplicated in 2017 commit 3d87209.
Contributor
Author
|
I have developed this fix independently, but one of the two patches quoted in the original bug report has the same correct fix (the other one should not be used). AFAICT, there are other places in Squid code where |
rousskov
added
the
S-could-use-an-approval
kinkie
approved these changes
Apr 18, 2026
Contributor
|
LGTM |
kinkie
added
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Apr 19, 2026
This surgical fix restricts parsing to the input buffer when the listing entry date in "TypeA" or "TypeB" formats is not followed by a filename. It does not improve rendering of listings with missing filenames or the overall quality of FTP listing parsing code. C strchr() always returns a non-nil pointer when given a NUL character, so its callers must be careful not to supply a NUL character if a "natural" one-of-the-regular-c-string-characters membership test is required. The bug was probably introduced in 1997 commit 3fdadc7 and then duplicated in 2017 commit 3d87209.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Apr 20, 2026
…#2408) This surgical fix restricts parsing to the input buffer when the listing entry date in "TypeA" or "TypeB" formats is not followed by a filename. It does not improve rendering of listings with missing filenames or the overall quality of FTP listing parsing code. C strchr() always returns a non-nil pointer when given a NUL character, so its callers must be careful not to supply a NUL character if a "natural" one-of-the-regular-c-string-characters membership test is required. The bug was probably introduced in 1997 commit 3fdadc7 and then duplicated in 2017 commit 3d87209.
squidadm
removed
the
backport-to-v7
Collaborator
|
queued for backport to v7 |
rousskov
removed
the
S-could-use-an-approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This surgical fix restricts parsing to the input buffer when the listing
entry date in "TypeA" or "TypeB" formats is not followed by a filename.
It does not improve rendering of listings with missing filenames or the
overall quality of FTP listing parsing code.
C strchr() always returns a non-nil pointer when given a NUL character,
so its callers must be careful not to supply a NUL character if a
"natural" one-of-the-regular-c-string-characters membership test is
required.
The bug was probably introduced in 1997 commit 3fdadc7 and then
duplicated in 2017 commit 3d87209.