Skip to content
Please note that GitHub no longer supports Internet Explorer.

We recommend upgrading to the latest Microsoft Edge, Google Chrome, or Firefox.

Learn more
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request URL generation in reverse proxy configurations #519

Conversation

@guidovranken
Copy link
Contributor

guidovranken commented Dec 10, 2019

No description provided.

Signed-off-by: Guido Vranken <guidovranken@gmail.com>
@squid-prbot

This comment has been minimized.

Copy link
Collaborator

squid-prbot commented Dec 10, 2019

Can one of the admins verify this patch?

rousskov added 3 commits Dec 10, 2019
TODO: Has the branch code missed the "IPv6 address without a port" case?
Copy link
Contributor

rousskov left a comment

Thanks a lot for working on this!

I committed a few polishing touches to your PR branch. One of them (commit 246989f) appears to expose a problem. Please review my commits and adjust as needed.

src/client_side.cc Outdated Show resolved Hide resolved
@yadij
yadij approved these changes Dec 11, 2019
Copy link
Contributor

rousskov left a comment

Thank you for addressing my concern. Glad the code became much simpler.

I polished the comment wording a little and will clear the PR.

@rousskov rousskov changed the title Fix stack buffer overflow, data leak in prepareAcceleratedURL Fix request URL generation in reverse proxy configurations Dec 12, 2019
@rousskov

This comment has been minimized.

Copy link
Contributor

rousskov commented Dec 12, 2019

I adjusted PR title to be less developer-specific. I adjusted PR description because the Squid Project uses commit Author field (which should be set to @guidovranken by Anubis), instead of Signed-off-by pseudo-headers.

@guidovranken, please feel free to add yourself to CONTRIBUTORS (IIRC that will eventually happen semi-automatically based on the Author field, but I do not know how often that synchronization happens).

Due to these potentially sensitive changes, I removed M-cleared-for-merge label to give others a chance to weigh in before the PR is auto-merged.

@rousskov

This comment has been minimized.

Copy link
Contributor

rousskov commented Dec 12, 2019

OK to test

@yadij

This comment has been minimized.

Copy link
Contributor

yadij commented Dec 12, 2019

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.