Fix request URL generation in reverse proxy configurations#519
Closed
guidovranken wants to merge 6 commits intosquid-cache:masterfrom
guidovranken:prepareAcceleratedURL-buffer-overflow-fix
Closed
Fix request URL generation in reverse proxy configurations#519guidovranken wants to merge 6 commits intosquid-cache:masterfrom guidovranken:prepareAcceleratedURL-buffer-overflow-fix
guidovranken wants to merge 6 commits intosquid-cache:masterfrom
guidovranken:prepareAcceleratedURL-buffer-overflow-fix
Conversation
Signed-off-by: Guido Vranken <guidovranken@gmail.com>
Collaborator
|
Can one of the admins verify this patch? |
TODO: Has the branch code missed the "IPv6 address without a port" case?
yadij
approved these changes
Dec 11, 2019
yadij
added
S-waiting-for-more-reviewers
rousskov
approved these changes
Dec 12, 2019
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
Thank you for addressing my concern. Glad the code became much simpler.
I polished the comment wording a little and will clear the PR.
rousskov
added
M-cleared-for-merge
rousskov
changed the title
rousskov
added
S-waiting-for-committer
Contributor
|
I adjusted PR title to be less developer-specific. I adjusted PR description because the Squid Project uses commit Author field (which should be set to @guidovranken by Anubis), instead of @guidovranken, please feel free to add yourself to Due to these potentially sensitive changes, I removed |
Contributor
|
OK to test |
yadij
added
M-cleared-for-merge
Contributor
|
LGTM |
squid-anubis
pushed a commit
that referenced
this pull request
Dec 12, 2019
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Jan 4, 2020
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Jan 16, 2020
yadij
pushed a commit
that referenced
this pull request
Jan 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.