Adding support for Laravel 13#104
Conversation
|
@danharrin is that time of the year :) Whenever you find the time please run the tests. |
|
The tests have now run, there are some failures |
|
Thanks @danharrin ! Tests are passing now. |
There was a problem hiding this comment.
Can you explain the problem that caused these changes and how they work to solve the problem?
There was a problem hiding this comment.
Because in Laravel 13: Creating a new model instance while that model is still booting is now disallowed and throws a LogicException.
So instead I resolve the table name through reflection if possible or just by using the Laravel model/table name convention.
In addition the data insert is done through a query builder connection instead of the Model insert.
I know it's ideal, but this way it works for all the Laravel versions supported. Otherwise we would have to release this only for L13+ and work on a more elegant solution.
Your call.
aglipanci
left a comment
There was a problem hiding this comment.
I left my comment on the logic behind the update.
Basically what title says :)