Push assets to release#130
Merged
Merged
Conversation
Contributor
Author
|
I think I'd need |
rporres
reviewed
Feb 16, 2018
| - make packages | ||
| debug: true | ||
| when: | ||
| event: tag |
There was a problem hiding this comment.
Bad format. It should be enclosed in []
Contributor
Author
There was a problem hiding this comment.
There was a problem hiding this comment.
It may work, but the rest of the actions in the drone file (and others we're building) are enclosed in brackets, so in order to be consistent please use the same event action format. Thx!
rporres
reviewed
Feb 16, 2018
| api_key: ${GITHUB_TOKEN} | ||
| files: build/*.tar.gz | ||
| when: | ||
| event: tag |
|
I don't really get what you are trying to do here 😅 |
dpordomingo
force-pushed
the
releasing
branch
from
a6eadfd to
8ec33a4
Compare
Contributor
Author
|
thanks @rporres for take a look to the PR.
|
dpordomingo
force-pushed
the
releasing
branch
from
8ec33a4 to
9186dbb
Compare
Contributor
Author
smacker
approved these changes
Feb 20, 2018
carlosms
approved these changes
Feb 20, 2018
Contributor
Author
|
Can you ptal @bzz ? |
bzz
approved these changes
Feb 21, 2018
Contributor
bzz
left a comment
bzz
left a comment
There was a problem hiding this comment.
LGTM
thank you @dpordomingo @rporres !
rporres
approved these changes
Feb 21, 2018
dpordomingo
force-pushed
the
releasing
branch
from
e5c025a to
d4403bb
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #70
depends on #139
With this PR drone should be able to upload into the release that is been created, the artifacts created by
make packagesIt will be used drone-github-release plugin
It will be needed to configure the following secret in drone
github_token(https://github.com/src-d/issues-infrastructure/issues/136)