New chart version #294
Merged
New chart version #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Riosalido <driosalido@sourced.tech>
Contributor
Author
|
Waiting until src-d/charts#122 gets merged. |
rporres
approved these changes
Dec 12, 2018
|
Since src-d/charts#122 has been merged, this is ready to go |
carlosms
approved these changes
Dec 13, 2018
Contributor
carlosms
left a comment
carlosms
left a comment
There was a problem hiding this comment.
LGTM. Feel free to merge at your discretion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new chart version, the Ingress section has to be explicitly defined.
Now there are two helm value files, one that has all the common values
for every environment .helm-defaults.yml and one specific for the staging environment .helm-staging.yml
The ingress is defined in the .helm-staging.yml file
Signed-off-by: David Riosalido driosalido@sourced.tech