This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Refactor to use core.ObjectReader and core.ObjectWriter #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JoshuaSjoding
commented
Feb 25, 2016
JoshuaSjoding
commented
- New function signatures provide the necessary interface to stream data from disk when using filesystem-based storage in the future
- New function signatures provide proper error handling
- ObjectReader and ObjectWriter interfaces added to avoid future refactoring, currently are type aliases for io.ReadCloser and io.WriteCloser respectively
- Object.Reader now returns (ObjectReader, error)
- Object.Writer now returns (ObjectWriter, error)
- File.Contents now returns (string, error)
- File.Lines now returns ([]string, error)
- Blob.Reader now returns (core.ObjectReader, error)
- Added internal close helper function for deferred calls to Close that need to check the return value
* New function signatures provide the necessary interface to stream data from disk when using filesystem-based storage in the future * New function signatures provide proper error handling * ObjectReader and ObjectWriter interfaces added to avoid future refactoring, currently are type aliases for io.ReadCloser and io.WriteCloser respectively * Object.Reader now returns (ObjectReader, error) * Object.Writer now returns (ObjectWriter, error) * File.Contents now returns (string, error) * File.Lines now returns ([]string, error) * Blob.Reader now returns (core.ObjectReader, error) * Added internal close helper function for deferred calls to Close that need to check the return value
Current coverage is
|
Contributor
|
Make sense. |
mcuadros
added a commit
that referenced
this pull request
Feb 25, 2016
Refactor to use core.ObjectReader and core.ObjectWriter
mcuadros
added a commit
that referenced
this pull request
Jan 31, 2017
Refactor to use core.ObjectReader and core.ObjectWriter
gsalingu-ovhus
pushed a commit
to gsalingu-ovhus/go-git
that referenced
this pull request
Mar 28, 2019
Add FAQ in README, with nginx problem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.