This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Substitute old pktline encoder/decoder with new pktline scanner #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smola
changed the title
mcuadros
approved these changes
Oct 18, 2016
Contributor
mcuadros
left a comment
mcuadros
left a comment
There was a problem hiding this comment.
I don't like the pktline.NewFromStrings but in pro of release v4, I am ok with it.
mcuadros
force-pushed
the
master
branch
2 times, most recently
from
ec55174 to
f544bb5
Compare
mcuadros
pushed a commit
that referenced
this pull request
Jan 31, 2017
* replace old pktline package with new pktline scanner * remove error checks on pktline.NewFromString * fix deppend bug * reduce memory garbage when pktline.NewFromStrings * improve int to hex conversion to help gc * make intToHex func private * clean function names
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the new pack protocol implementation (package
packp), this patch replaces the old pktline package with a new one, inspired on the standard golang scanner API and using []bytes instead of strings where ever possible.There are some inefficiencies involving []byte to string translations that will disappear in the future when we migrate the whole git-upload-pack-things to the new packp support.