integrate change from src-d/ml nn tokenizer #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarkovtsev
requested changes
May 8, 2019
vmarkovtsev
requested changes
May 8, 2019
Collaborator
vmarkovtsev
left a comment
vmarkovtsev
left a comment
There was a problem hiding this comment.
Good job! This will take a few more days to get merged I guess.
zurk
suggested changes
May 16, 2019
vmarkovtsev
requested changes
May 16, 2019
Collaborator
Contributor
Author
|
@vmarkovtsev I thought I started following the guidelines about the commit messages already. Do you want me to edit all old commit messages to add the cap at the first letter ? |
Collaborator
|
Yes, run an interactive rebase and reword all the commits. |
vmarkovtsev
requested changes
May 20, 2019
vmarkovtsev
approved these changes
May 20, 2019
Contributor
|
@glimow can I ask you to rebase your commits to the current master and I will merge? |
Signed-off-by: Tristan Kalos <tristan.kalos@live.fr>
Signed-off-by: Tristan Kalos <tristan.kalos@live.fr>
Add doscstrings Add model parameters into asdf file Change model name to IdentifierSplitterBiLSTM Signed-off-by: tristan kalos <tristan.kalos@live.fr>
Signed-off-by: tristan kalos <tristan.kalos@live.fr>
Signed-off-by: tristan kalos <tristan.kalos@live.fr>
Contributor
Author
|
Sure. It should be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the NN id splitter to src-d/ml-core. PR migrated from src-d/ml#405
Note that I separated original PR into two. This one only adds the neural network model code, but do not modifiy the
tokenparserso it can be merged before src-d/models#18