feat(logic) keep optimize time calculation#30
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Status Fixer SourceMod plugin to optimize the player “connected time” calculation in the enhanced status output and bumps the plugin version accordingly.
Changes:
- Bump plugin version from
2.1.6to2.1.7. - Optimize connected-time formatting by flooring client time once and performing integer hour/minute/second math.
Comment on lines
174
to
+179
| if (!IsFakeClient(player)) | ||
| { | ||
| float fTime = GetClientTime(player); | ||
| int iHours = RoundToFloor((fTime / 3600)); | ||
| int iMinutes = RoundToFloor((fTime - (iHours * 3600)) / 60); | ||
| int iSeconds = RoundToFloor((fTime - (iHours * 3600)) - (iMinutes * 60)); | ||
| int iTime = RoundToFloor(GetClientTime(player)); | ||
| int iHours = iTime / 3600; | ||
| int iMinutes = (iTime - (iHours * 3600)) / 60; | ||
| int iSeconds = iTime - (iHours * 3600) - (iMinutes * 60); |
There was a problem hiding this comment.
For fake clients this block is skipped, leaving sPlayerTime/sPlayerPing/sPlayerLoss uninitialized but still printed later in the row. This can produce garbage output (or stale values if the stack happens to contain previous data). Initialize these fields to sensible defaults before the if (!IsFakeClient(player)) or add an else branch that formats placeholders for bots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.