Introduce FamilyDataService and USPTOService to enrich OPS family data and harden parsing#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
inventor/applicantby making parsing defensive.Pdo\Mysqlsymbol in environments where it may not be defined.Description
app/Services/FamilyDataService.phpwhich orchestratesOPSServiceand newly addedUSPTOServiceand returns either OPS families or USPTO-enriched data viagetFamilyMembers.app/Services/USPTOService.phpwhich queries configurable USPTO ODP endpoints, normalizes payloads intotitle,applicants,inventors, andprocedure, and exposesenrichFamilyMembersandgetApplicationDatahelpers.app/Services/OPSService.phpparsing to safely handle missing nodes and to filter/normalize applicant and inventor lists before assigning them to the family array.app/Http/Controllers/MatterController.phpto inject and useFamilyDataService(replacing directOPSServicecalls) and added empty-array guards before iteratingapplicants/inventorswhen creating matters.config/services.phpunder ausptokey and madeconfig/database.phphandle thePdo\Mysqlsymbol more defensively.Testing
phpunitandphp artisan test, and the existing tests completed successfully.Codex Task