Run tests as a flake check; macOS CI for tests #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srid
force-pushed
the
tests-flake
branch
2 times, most recently
from
cda6382 to
c4ff9f1
Compare
srid
changed the title
srid
force-pushed
the
tests-flake
branch
2 times, most recently
from
4f608c1 to
b920153
Compare
This currently works only on macOS. On Linux, the check fails due to missing network access.
Move Linux test to github ubuntu runner until we we can self host it.
We don't want to run this on every platform. Just one is sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #239
The flake check builds on Darwin, but not Linux. See #241