Borland Updates March 21, 2022

[jhs507]

Updates were made to the Borland source to correct various issues. These changes need to be made in the crhmcode version and merged in.

[jhs507]

List of changes also found in notes.txt

CRHM 08/11/21

Add fallstat_correction parameter in Volumetric module to allow correction for the estimated fallstat, with default value as 1.

if(fallstat_correction[hh] >= 0.0)
   fallstat[hh] = fallstat[hh]*fallstat_correction[hh];

CRHM 03/18/22

In Canopy, CanopyClearing, and CanopyClearingGap module, removing Gamma Distribution Correction term (1.0 + 3.0/Alpha + 2.0/sqr(Alpha))
term in mean particle mass equation, correction as,
Mpm = 4.0/3.0 * M_PI * PBSM_constants::DICE * RadiusRadiusRadius;

In evap module, /86400 to ra term for rs/ra in Penman-Monteith method, because rs is in d/m while ra is in s/m, correction as,

   evap[hh] = (delta(hru_t[hh])*Q*Global::Freq + (RHOa*Cp/
              (lambda(hru_t[hh])*1e3)*(estar(hru_t[hh]) - hru_ea[hh])/(ra/86400)))/
              (delta(hru_t[hh]) + gamma(Pa[hh], hru_t[hh])*(1.0 + rs[hh]/(ra/86400)))/
              Global::Freq;

CRHM 03/21/22

In Canopy, CanopyClearing, and CanopyClearingGap module, invert the time step conversion term in weekly dimensionless unloading coefficient,
use unloading rate coefficient U = -log(c)/t for snow unloading determined by inverse function of c = e^(-Ut) = 0.678 based on Eq. 14 in Hedstrom and Pomeroy (1998)
correction as,
const float U = -1log(0.678)/(247*Global::Freq/24);

   else if(IceBulbT < unload_t[hh]) // has to be at least one interval. Trip on half step
        SUnload[hh] = Snow_load[hh]*U; // the dimensionless unloading coefficient already /interval, 21Mar2022 correction: use unloading rate coefficient U

CRHM 04/06/22

Update description for parameters, variables and units in the modules below:

longVt
netall
evap_Resist
evapD_Resist
ShuttleWallace
ShuttleWallaceD
crack
PrairieInfiltration
Ayers
Greencrack
GreenAmpt
frozen
frozenAyers
Soil
evapX
SoilX
SoilDetention
SoilPrairie
glacier
SWESlope
Netroute
Netroute_D
Netroute_M
Netroute_M_D
REW_route
REW_route2
Canopy
CanopyClearing
CanopyClearingGap
NeedleLeaf
XG
Volumetric
tsurface
K_Estimate
interception
lake_evap  

[jhs507]

@lawfordp2017 You had a question about one of the changes earlier was that resolved?

[loganxingfang]

There should be one commit for the change on Line 29 in the Classinterception.cpp:

declvar("net_snow", TDim::NHRU, "Canopy unload ", "(kg/m^2*int)", &net_snow);

[jhs507]

I have updated Classinterception

[jhs507]

Are there more updates to implement or is this ready to be merged in?

[loganxingfang]

Are there more updates to implement or is this ready to be merged in?

These will be all updates for this time.

When my review comments above from yesterday are addressed, I think it is ready to be merged in.