Merged
Conversation
Collaborator
|
These changes look good to me. Should other modelers weigh in or are the corrections just fixing an error? |
Collaborator
|
@loganxingfang Just following up on this should this be merged or should other modelers weigh in? |
Collaborator
Author
|
For issue mentioned about module variation#5 in module glacier, it needs to fixed; otherwise user cannot construct prj when selecting glacier#5, as it would crash. For issue about hru_tsf estimation, it has been reviewed by Peter. The solution is also reviewed by John. |
Collaborator
|
Okay this looks good to merge to me. I will be working on a new release today and this should be included. |
Collaborator
Author
|
Thank you Justin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: