Skip to content

Crhm tsurface correction15 mar2023#426

Merged
jhs507 merged 2 commits intomasterfrom
CRHM_tsurface_correction15Mar2023
Sep 8, 2023
Merged

Crhm tsurface correction15 mar2023#426
jhs507 merged 2 commits intomasterfrom
CRHM_tsurface_correction15Mar2023

Conversation

@loganxingfang
Copy link
Collaborator

Changes:

  1. added corrections for hru_tsf estimation in module tsurface.
  2. added description of module variation#5 in module glacier; this could be solution to the Issue glacier#5 crashes in Construct GUI #423.

@jhs507
Copy link
Collaborator

jhs507 commented Mar 16, 2023

These changes look good to me. Should other modelers weigh in or are the corrections just fixing an error?

@jhs507
Copy link
Collaborator

jhs507 commented Sep 8, 2023

@loganxingfang Just following up on this should this be merged or should other modelers weigh in?

@loganxingfang
Copy link
Collaborator Author

For issue mentioned about module variation#5 in module glacier, it needs to fixed; otherwise user cannot construct prj when selecting glacier#5, as it would crash.

For issue about hru_tsf estimation, it has been reviewed by Peter. The solution is also reviewed by John.

@jhs507
Copy link
Collaborator

jhs507 commented Sep 8, 2023

Okay this looks good to merge to me.

I will be working on a new release today and this should be included.

@jhs507 jhs507 merged commit 0a6797e into master Sep 8, 2023
@loganxingfang
Copy link
Collaborator Author

Thank you Justin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants