Added new output variable useful for canopy snow sublimation research#436
Merged
jhs507 merged 2 commits intosrlabUsask:masterfrom Nov 14, 2023
Merged
Added new output variable useful for canopy snow sublimation research#436jhs507 merged 2 commits intosrlabUsask:masterfrom
jhs507 merged 2 commits intosrlabUsask:masterfrom
Conversation
jhs507
approved these changes
Nov 14, 2023
Collaborator
jhs507
left a comment
jhs507
left a comment
There was a problem hiding this comment.
This looks good to me.
Have you ran a test model where you output the new variable?
Collaborator
|
This is good addition to output the "dimensionless canopy sublimation rate", as Alex did. This can also be added to ClassCRHMCanopy.cpp/ClassCRHMCanopy.h, ClassCRHMCanopyClearing.cpp/ClassCRHMCanopyClearing.h I will create the pull request for them. I will also add this in Borland CRHM relevant canopy modules. |
loganxingfang
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pot_subl_spy variable (already calculated by CRHM but was private) was added as a possible public output variable. This is the 'dimensionless canopy sublimation rate' in units per second. This variable is used to multiple by the canopy snow load to calculate the sublimation of snow from the canopy. It is useful to output this variable to calculate canopy sublimation rate using the canopy snow load measured using a weighed tree lysimeter instead of the CRHM simulated canopy snow load.