Fix the link to the image for the page#562
Merged
PeterJCLaw merged 1 commit intomainfrom Apr 15, 2024
Merged
Conversation
This is used in our header tags but not currently on the page itself, so this would have been affecting social media previews of the article.
RealOrangeOne
approved these changes
Apr 15, 2024
Member
RealOrangeOne
left a comment
RealOrangeOne
left a comment
There was a problem hiding this comment.
Perhaps a way to ensure this is to use page.image in the below include? (I think that's possible)
Member
Author
Yeah, thought about that. Not sure we want to couple the two given the size of the image we want to embed, plus there may be other cases which better validation would solve for. Also wanted this to be a minimal quick fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is used in our header tags but not currently on the page itself, so this would have been affecting social media previews of the article.