Skip to content

🎨 Palette: Add pagination to documentation pages#2783

Merged
srod merged 2 commits intodevelopfrom
palette-docs-pagination-7195916456732784843
Jan 16, 2026
Merged

🎨 Palette: Add pagination to documentation pages#2783
srod merged 2 commits intodevelopfrom
palette-docs-pagination-7195916456732784843

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Jan 14, 2026

💡 What: Added a new Pagination component to the documentation site.
🎯 Why: To improve user navigation by providing convenient "Previous" and "Next" links at the bottom of each documentation page, allowing for linear reading.
📸 Before/After: Added Previous/Next buttons at the bottom of the page content area.
♿ Accessibility: Used semantic <nav>, aria-label, rel attributes, and clear focus indicators for keyboard users.


PR created automatically by Jules for task 7195916456732784843 started by @srod


Summary by cubic

Adds Previous/Next pagination to documentation pages based on the sidebar order. Improves navigation and supports linear reading across topics.

  • New Features
    • Added Pagination.astro that derives prev/next from SIDEBAR and current path, rendered in MainLayout below page content, with a safe fallback when the page isn’t in the sidebar.
    • Accessible and theme-aligned: semantic nav, aria-label, rel="prev/next", clear focus states, and non-shrinking icons.

Written for commit 2c08fe6. Summary will update on new commits.

@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026

⚠️ No Changeset found

Latest commit: 2c08fe6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Comment @coderabbitai help to get the list of available commands and usage tips.

@srod srod force-pushed the palette-docs-pagination-7195916456732784843 branch 3 times, most recently from a6e8e88 to ad50008 Compare January 16, 2026 16:39
- Created `Pagination` component to generate Previous/Next links based on sidebar structure.
- Integrated `Pagination` into `MainLayout` to appear at the bottom of content pages.
- Added accessibility features (aria-labels, focus outlines, semantic HTML).
- Styled with existing design system variables.
@srod srod force-pushed the palette-docs-pagination-7195916456732784843 branch from ad50008 to 2607b43 Compare January 16, 2026 21:26
@srod srod marked this pull request as ready for review January 16, 2026 21:28
@greptile-apps
Copy link

greptile-apps bot commented Jan 16, 2026

Skipped: This PR was opened by one of your excluded authors: (google-labs-jules[bot])

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="docs/src/components/Pagination.astro">

<violation number="1" location="docs/src/components/Pagination.astro:16">
P2: Guard against `findIndex` returning -1. Without bounds checks, a page that isn’t in SIDEBAR still renders a “Next” link to the first entry, which is misleading navigation.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@srod srod merged commit 39c15c5 into develop Jan 16, 2026
12 of 15 checks passed
@srod srod deleted the palette-docs-pagination-7195916456732784843 branch January 16, 2026 21:57
@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.37%. Comparing base (6dc83f9) to head (2c08fe6).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2783   +/-   ##
========================================
  Coverage    99.37%   99.37%           
========================================
  Files           63       63           
  Lines         1277     1277           
  Branches       391      391           
========================================
  Hits          1269     1269           
  Misses           8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant