chore: update dependencies and refactor workflow stages #55
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,11 @@ | ||||||||||
| import js from '@eslint/js' | ||||||||||
| import globals from "globals"; | ||||||||||
| import reactHooks from "eslint-plugin-react-hooks"; | ||||||||||
| import reactRefresh from "eslint-plugin-react-refresh"; | ||||||||||
| import tseslint from '@typescript-eslint/eslint-plugin' | ||||||||||
| import tsparser from '@typescript-eslint/parser' | ||||||||||
| import prettierConfig from 'eslint-config-prettier' | ||||||||||
| import { globalIgnores } from "eslint/config"; | ||||||||||
|
There was a problem hiding this comment. The import
Suggested change
|
||||||||||
|
|
||||||||||
| const ignores = [ | ||||||||||
| 'eslint.config.js', | ||||||||||
|
|
@@ -46,7 +50,10 @@ const ignores = [ | |||||||||
|
|
||||||||||
| export default [ | ||||||||||
| { ignores }, | ||||||||||
| globalIgnores(["dist", "node_modules"]), | ||||||||||
|
Contributor
There was a problem hiding this comment. The use of There was a problem hiding this comment. style: This Prompt To Fix With AIThis is a comment left during a code review.
Path: eslint.config.js
Line: 53:53
Comment:
**style:** This `globalIgnores` call is redundant - `dist` and `node_modules` are already in the `ignores` array above (lines 14-15). Consider removing this line.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
52
to
+53
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Remove redundant The { ignores },
- globalIgnores(["dist", "node_modules"]),
js.configs.recommended,📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsThere was a problem hiding this comment. This usage of |
||||||||||
| js.configs.recommended, | ||||||||||
| reactHooks.configs.flat.recommended, | ||||||||||
| reactRefresh.configs.next, | ||||||||||
|
There was a problem hiding this comment. style: Verify that Prompt To Fix With AIThis is a comment left during a code review.
Path: eslint.config.js
Line: 56:56
Comment:
**style:** Verify that `reactRefresh.configs.next` exists - the standard config is typically `reactRefresh.configs.recommended` or a custom flat config object
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment. The configuration reference
Suggested change
|
||||||||||
| prettierConfig, | ||||||||||
| { | ||||||||||
| files: ['**/*.ts', '**/*.tsx'], | ||||||||||
|
|
@@ -55,6 +62,7 @@ export default [ | |||||||||
| }, | ||||||||||
| languageOptions: { | ||||||||||
| parser: tsparser, | ||||||||||
| globals: globals.browser, | ||||||||||
|
Comment on lines
63
to
+65
There was a problem hiding this comment. issue (bug_risk): Applying Because this config applies |
||||||||||
| parserOptions: { | ||||||||||
| ecmaVersion: 2022, | ||||||||||
| sourceType: 'module', | ||||||||||
|
|
||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,13 @@ | ||||||
| import { type ClassValue, clsx } from "clsx" | ||||||
| import { twMerge } from "tailwind-merge" | ||||||
| import { v4 as uuid } from "@lukeed/uuid"; | ||||||
|
There was a problem hiding this comment. syntax: Missing dependency:
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: lib/utils.ts
Line: 3:3
Comment:
**syntax:** Missing dependency: `@lukeed/uuid` is imported but not present in `package.json`
```suggestion
import { v4 as uuid } from "uuid";
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||
|
|
||||||
| export function cn(...inputs: ClassValue[]) { | ||||||
| return twMerge(clsx(inputs)) | ||||||
| } | ||||||
| export function newThreadLink( | ||||||
| rootPath: string, | ||||||
| agentId: string, | ||||||
| ): `/${string}/${string}/chat/${string}?new=true` { | ||||||
|
There was a problem hiding this comment. The function
Suggested change
|
||||||
| return `/${rootPath}/${agentId}/chat/${uuid()}?new=true`; | ||||||
|
Comment on lines
+8
to
+12
There was a problem hiding this comment. suggestion: Consider normalizing If callers pass |
||||||
| } | ||||||
|
Comment on lines
+8
to
+13
There was a problem hiding this comment. 🧹 Nitpick | 🔵 Trivial Add TSDoc documentation and consider input validation. The function lacks TSDoc documentation. Per coding guidelines, public APIs should include parameter descriptions, return types, and examples. Additionally, consider validating/sanitizing +/**
+ * Generates a new chat thread URL path with a unique identifier.
+ * @param rootPath - The root path segment (e.g., 'app', 'dashboard')
+ * @param agentId - The agent identifier
+ * @returns A URL path in the format `/{rootPath}/{agentId}/chat/{uuid}?new=true`
+ * @example
+ * newThreadLink('app', 'agent-123')
+ * // => '/app/agent-123/chat/550e8400-e29b-41d4-a716-446655440000?new=true'
+ */
export function newThreadLink(
rootPath: string,
agentId: string,
): `/${string}/${string}/chat/${string}?new=true` {
return `/${rootPath}/${agentId}/chat/${uuid()}?new=true`;
}🤖 Prompt for AI Agents |
||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -269,7 +269,7 @@ const convertPdfToMarkdownStep = createStep({ | |||||||||||||
| data: { | ||||||||||||||
| status: 'in-progress', | ||||||||||||||
| message: 'Converting PDF to markdown `...', | ||||||||||||||
| stage: "convert-pdf-to-markdown", | ||||||||||||||
|
Comment on lines
271
to
+272
There was a problem hiding this comment. Fix typo: stray backtick in message string. The message contains an errant backtick that appears unintentional. status: 'in-progress',
- message: 'Converting PDF to markdown `...',
+ message: 'Converting PDF to markdown...',
stage: "convert-pdf-to-markdown",📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
| }, | ||||||||||||||
| id: "convert-pdf-to-markdown", | ||||||||||||||
| }); | ||||||||||||||
|
|
@@ -318,7 +318,7 @@ const convertPdfToMarkdownStep = createStep({ | |||||||||||||
| data: { | ||||||||||||||
| status: "in-progress", | ||||||||||||||
| message: 'Markdown conversion complete (90%)...', | ||||||||||||||
| stage: "convert-pdf-to-markdown", | ||||||||||||||
| }, | ||||||||||||||
| id: "convert-pdf-to-markdown", | ||||||||||||||
| }); | ||||||||||||||
|
|
@@ -345,7 +345,7 @@ const convertPdfToMarkdownStep = createStep({ | |||||||||||||
| data: { | ||||||||||||||
| status: "done", | ||||||||||||||
| message: "PDF converted to markdown successfully", | ||||||||||||||
| stage: 'convert-pdf-to-markdown', | ||||||||||||||
| }, | ||||||||||||||
| id: "convert-pdf-to-markdown", | ||||||||||||||
| }); | ||||||||||||||
|
|
@@ -360,9 +360,10 @@ const convertPdfToMarkdownStep = createStep({ | |||||||||||||
| logError('convert-pdf-to-markdown', error, { contentType: inputData.contentType }); | ||||||||||||||
|
|
||||||||||||||
| await writer?.custom({ | ||||||||||||||
| type: 'data-tool-progress', | ||||||||||||||
| data: { | ||||||||||||||
| stage: 'convert-pdf-to-markdown', | ||||||||||||||
| status: "done", | ||||||||||||||
| error: error instanceof Error ? error.message : 'Unknown error', | ||||||||||||||
|
There was a problem hiding this comment. The error data structure is inconsistent with other progress updates. Similar to other error handlers in this file, consider adding a 'message' field to provide better context. The current structure only includes 'stage', 'status', and 'error', while success cases include descriptive messages.
Suggested change
|
||||||||||||||
| }, | ||||||||||||||
| id: "convert-pdf-to-markdown", | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Verify that
globalIgnoresexport exists ineslint/config- this import path may not be valid for ESLintPrompt To Fix With AI