Update bundle scripts to handle installation directory being moved#296
Merged
djhoese merged 2 commits intossec:masterfrom Jun 9, 2020
Merged
Update bundle scripts to handle installation directory being moved#296djhoese merged 2 commits intossec:masterfrom
djhoese merged 2 commits intossec:masterfrom
Conversation
Contributor
|
I updated the .bat script and tested it on Windows, but I'm not sure why the tests are failing like this... |
Member
Author
|
Looks like a new version of pyvirtualdisplay is breaking things for pytest xvfb: The-Compiler/pytest-xvfb#22 Let's give it 24 hours and then see where things stand. We can limit the version of pyvirtualdisplay to <1.0 if we have to. |
Member
Author
|
A new version of pytest-xvfb just came out, I restarted the tests, and now things seem to be passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #295. At the time of writing this is just the
.shscript, but should work.I started researching
.batfile solutions and came across this: https://stackoverflow.com/questions/130116/windows-batch-commands-to-read-first-line-from-text-file. I'm not sure how Windows handles newlines and carriage returns the way @katherinekolman has it writing to the file. Kat do you think you could look in to this and test it on Windows? The idea is that if you run SIFT once, then move the directory to a new directory and run it again, conda-unpack should run and data should load fine.