Skip to content

Conversation

@jesusvazquez
Copy link
Contributor

No description provided.

@jesusvazquez
Copy link
Contributor Author

Hi guys, first I would like to thank you for uploading this repository, it is really useful for me.

In this PR you will find two new methods in both services Youtube and Vimeo:

  • parseVIdFromURL: Returns the video id from the original video url.
  • getVideoRawData: Returns the original API response. The function getVideoDetail is really nice but eventually you may want to get something else.

I also edited the uploader key in the Youtube Service, from my POV youtube doesn't want us to see uploaders as a single user but as a channel.

'uploader'        => $data->items[0]->snippet->channelTitle

Let me know what you think!

Cheers

@jesusvazquez jesusvazquez changed the title Youtube uploader is now the channel title Youtube uploader and two new functions May 7, 2016
@sseffa sseffa merged commit 77a6849 into sseffa:master May 13, 2016
@sseffa
Copy link
Owner

sseffa commented May 14, 2016

thank you for PR but i don't understand your sentence

I also edited the uploader key in the Youtube Service, from my POV youtube doesn't want us to see uploaders as a single user but as a channel.

@jesusvazquez
Copy link
Contributor Author

jesusvazquez commented May 14, 2016

Let me try to clear this up.

If you check this line you will see that in the key:value array for the youtube video information, the value for the key uploader is now the channelTitle. Before it was null.

I did this because in the API response they provide the channeltitle not the username or email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants