Skip to content

Update compilation instructions#40

Closed
zhogov wants to merge 1 commit intossh-vault:masterfrom
zhogov:patch-4
Closed

Update compilation instructions#40
zhogov wants to merge 1 commit intossh-vault:masterfrom
zhogov:patch-4

Conversation

@zhogov
Copy link
Contributor

@zhogov zhogov commented Feb 7, 2020

  • Have you test the code?
  • Have you check that the existing tests are passing?
  • The destination branch is develop?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 74.572% when pulling fa43e8f on zhogov:patch-4 into a72db6d on ssh-vault:master.

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #40 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   68.99%   68.99%           
=======================================
  Files          12       12           
  Lines         329      329           
=======================================
  Hits          227      227           
  Misses         62       62           
  Partials       40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72db6d...fa43e8f. Read the comment docs.

@nbari
Copy link
Member

nbari commented Feb 7, 2020

Hi @zhogov #39 maybe is easy to have all changes in one PR

@zhogov
Copy link
Contributor Author

zhogov commented Feb 7, 2020

Don't see a problem with 2 PRs, but this on was opened against master, so ok, I will make one unified PR

@zhogov zhogov closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants