Skip to content

Fixing update snapshot hanging#192

Merged
LasseEngboChr merged 8 commits intomainfrom
fix/update_snapshot_hanging
Mar 28, 2025
Merged

Fixing update snapshot hanging#192
LasseEngboChr merged 8 commits intomainfrom
fix/update_snapshot_hanging

Conversation

@LasseEngboChr
Copy link
Copy Markdown
Contributor

@LasseEngboChr LasseEngboChr commented Mar 26, 2025

At random update_snapshot hangs after writing "After to_add". This is issue #191

Intent

Solves issue #191

Additional log_info output is adjusted to reduce lines that comes after almost zero computation time.

Approach

The issue was resolved by adding a compute of currently_valid_checksums.

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@LasseEngboChr
Copy link
Copy Markdown
Contributor Author

Seems like the SQL Server 2022 fails due to a problem with datatypes. Was the CI DB backends changed?

@LasseEngboChr LasseEngboChr self-assigned this Mar 27, 2025
@RasmusSkytte RasmusSkytte linked an issue Mar 27, 2025 that may be closed by this pull request
@RasmusSkytte
Copy link
Copy Markdown
Contributor

Seems like the SQL Server 2022 fails due to a problem with datatypes. Was the CI DB backends changed?

Could be something changed in the workflow that starts the instance (not our workflow).

@LasseEngboChr
Copy link
Copy Markdown
Contributor Author

Seems like the SQL Server 2022 fails due to a problem with datatypes. Was the CI DB backends changed?

Could be something changed in the workflow that starts the instance (not our workflow).

I just check our local MS SQL Server Version 15.00.4375 and it provides the expected datatypes. A guess is that the CI version uses DATETIME2 instead of DATETIME - the latter is sufficient for our purpose.

@RasmusSkytte
Copy link
Copy Markdown
Contributor

Could also be an update to SQL Server 2022
https://sqlserverbuilds.blogspot.com/2021/07/sql-server-2022-versions.html

Copy link
Copy Markdown

@SofiaOtero SofiaOtero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but support of SQL Server 2022 should be added in a future PR.

@LasseEngboChr LasseEngboChr merged commit 187ac77 into main Mar 28, 2025
51 of 55 checks passed
@LasseEngboChr LasseEngboChr deleted the fix/update_snapshot_hanging branch March 28, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: update_snapshot blocks for it self at random

3 participants