fix(update_snapshot): Ensure filter is copied to source conn#201
Merged
RasmusSkytte merged 7 commits intomainfrom Oct 29, 2025
Merged
fix(update_snapshot): Ensure filter is copied to source conn#201RasmusSkytte merged 7 commits intomainfrom
RasmusSkytte merged 7 commits intomainfrom
Conversation
RasmusSkytte
approved these changes
Oct 29, 2025
Contributor
RasmusSkytte
left a comment
RasmusSkytte
left a comment
There was a problem hiding this comment.
Looks good!
Do you want to add an entry to the NEWS.md file about the fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
update_snapshotfailed if filters are on a different connection than the source table, e.g. a data.frame.Approach
The solution was to make a copy of the filter on the source connection when on different connections. Note that a similar action was already done for the target connection.
Known issues
Checklist
NEWS.md