Detect schema without tables in schema_exists#30
Merged
marcusmunch merged 4 commits intomainfrom Sep 7, 2023
Merged
Conversation
RasmusSkytte
approved these changes
Sep 7, 2023
Contributor
RasmusSkytte
left a comment
RasmusSkytte
left a comment
There was a problem hiding this comment.
Approved with a single suggestion
RasmusSkytte
reviewed
Sep 7, 2023
RasmusSkytte
reviewed
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out one of the issues I had regarding setting up GitHub actions was that
schema_existswould always returnFALSEunless a table existed in the schema.This is now fixed by trying to create a table (and immediately deleting it) if no tables were found within the schema. This does mean that the function will always return
FALSEon a schema with no tables if the user does not haveCREATE TABLEprivileges.A more hands-off, backend-specific (i.e. PostgreSQL-specific) solution could be made, but I opted for a potentially wider usable method.