Skip to content

feat: Better checks in get_connection#83

Merged
marcusmunch merged 5 commits intossi-dk:mainfrom
marcusmunch:get_connection-checks
Jan 16, 2024
Merged

feat: Better checks in get_connection#83
marcusmunch merged 5 commits intossi-dk:mainfrom
marcusmunch:get_connection-checks

Conversation

@marcusmunch
Copy link
Copy Markdown
Contributor

Intent

This PR decreases restriction on host, port, timezone and timezone_out arguments to get_connection.

Approach

From NEWS.md:

  • Improved checks on get_connection():
    • If given, host does not need to look like an IP address (e.g. "localhost" is not unrealistic).
    • A character input for port is allowed if it is a string of digits.
    • Now checks if timezone and timezone_out is an IANA time zone.

Known issues

N/A

Checklist

  • The PR passes all local unit tests
  • I have documented any new features introduced
  • If the PR adds a new feature, please add an entry in NEWS.md
  • A reviewer is assigned to this PR

@marcusmunch marcusmunch added the enhancement New feature or request label Jan 16, 2024
@marcusmunch marcusmunch requested a review from a team January 16, 2024 09:49
@marcusmunch marcusmunch self-assigned this Jan 16, 2024
@marcusmunch marcusmunch requested review from LasseEngboChr and RasmusSkytte and removed request for a team January 16, 2024 09:49
Copy link
Copy Markdown
Contributor

@RasmusSkytte RasmusSkytte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@marcusmunch marcusmunch merged commit 06fbf7f into ssi-dk:main Jan 16, 2024
@marcusmunch marcusmunch deleted the get_connection-checks branch January 16, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants