Updated Docs to DocGuide V1 (Adding Navigation Bar)#44
Merged
Conversation
Collaborator
Author
|
After this PR is merged, the READTHEDOCS will need to be taken down and the ServiceX_Website docs building script will need to be updates to use the new file format. |
Collaborator
Author
|
Deals with part of issue #43. |
Collaborator
|
Seems straightforward - is there a way to test it first? Once this is done, I will update the actual content |
Collaborator
Author
No way to test it other than building the docs locally. Checkout the Doc Guide for info how. I already did, everything looks good to me. |
github-project-automation
Bot
moved this from In review
to Done
in ServiceX Documentation and User Acquisition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the changes in how the documentation is going to be hosted for the website there are changes that need to be made to all docs in order to better support this unified front. This PR adds the NavBar to the docs as well as it makes some other changes in order to match the DocGuidelines that are outlined in the ServiceX_Website repo.