fix: improve sidebar working directory colour contrast with modified files (resolves #5184 #5188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariane-emory
changed the title
Collaborator
|
I think it'd be better to have a space if possible |
Contributor
Author
|
@rekram1-node I could certainly give that a shot, let me get some caffeine in me first and I'll take a stab at it. Were you imagining adding a single empty line to separate the final line in the modified files section from the first line of the working directory...
|
Contributor
Author
|
@rekram1-node Alright, pending your response I went with option #1: both. Just let me know if option #2 (spacing only, no colour change) is more your style and I'll make the change. I could go either way myself. Tokyo Night theme example:
|
ariane-emory
force-pushed
the
fix/sidebar-working-directory-color
branch
from
96c01be to
a52cc64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the colour used to display the current working directory in the sidebar from
mutedTexttosuccess, making the working directory more visually distinct from the modified files displayed above it. In most of the stock themes,textseems to be a color that has sufficient contrast to be visually distinguished easily fromtextMuted.Examples in some of the stock themes
Cobalt
With this PR:
Before this PR:
Matrix
With this PR:
Before this PR:
Catpuccin
With this PR:
Before this PR:
Resolves #5184.