Doxygen comments for 6 additional files #1051
Conversation
…t.h, exit.h, linkPair.h
…e.h, timeConverter.h, timeLord.h, unitAlgebra.h
…tory.h, mempool.h and mempoolAccessor.h
github-actions
bot
added
AT: WIP
|
CMAKE-FORMAT TEST - PASSED |
|
CLANG-FORMAT TEST - PASSED |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
feldergast
left a comment
feldergast
left a comment
There was a problem hiding this comment.
Some of these changes are missing important nuances. When I get more time, I will go through and make some detailed comments, but that probably won’t happen until at least next week.
|
|
||
| /** | ||
| * @return True if parent insert statistics are shared with the child | ||
| */ |
There was a problem hiding this comment.
Should instead be "True if child can insert its statistics into its parent's statistics set"
gvoskuilen
left a comment
gvoskuilen
left a comment
There was a problem hiding this comment.
Commented on a few things that should be fixed.
These are not comprehensive, still waiting on a review from @feldergast.
|
|
||
| /** | ||
| * @return True if the environment option is enabled | ||
| */ |
There was a problem hiding this comment.
True if environment configuration is disabled
|
|
||
| /** | ||
| * @return Logger | ||
| */ |
| /** | ||
| * @brief hasLibrary Checks to see if library exists and can be loaded | ||
| * @param elemlib | ||
| * @param elemlib Name of the Element Library Database |
There was a problem hiding this comment.
Just "Name of the element library" (not database)
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
4 participants
Files: