Use std::make_unique() for variable-length arrays instead of array[N] when N is not constant #1255

leekillough · 2025-03-16T13:21:50Z

Use std::make_unique() for variable-length arrays instead of array[N] when N is not constant. VLAs are non-standard, and allocate on the stack instead of the heap, which increases the chance of stack overflows.

github-actions · 2025-03-16T13:22:14Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-03-16T13:22:14Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-03-16T13:52:08Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-03-23T06:38:07Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-03-23T06:38:17Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-03-23T06:52:03Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-04-01T23:16:49Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-04-01T23:16:49Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-04-02T00:06:24Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-04-06T04:52:21Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-04-06T04:52:24Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-04-06T05:19:41Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

…s; add -Wvla

github-actions · 2025-04-10T05:24:33Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-04-10T05:24:42Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-04-10T05:50:36Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

github-actions · 2025-04-15T20:00:23Z

CLANG-FORMAT TEST - PASSED

github-actions · 2025-04-15T20:00:27Z

CMAKE-FORMAT TEST - PASSED

sst-autotester · 2025-04-15T20:20:01Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

sst-autotester · 2025-04-17T19:19:54Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

sst-autotester · 2025-04-17T19:25:47Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1972
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1928
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1927
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 875
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 727
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 681
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 494
Status: STARTED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 300
Status: STARTED

Using Repos:

Repo: CORE (leekillough/sst-core)

Repo: SQE (sstsimulator/sst-sqe)

Repo: ELEMENTS (sstsimulator/sst-elements)

Repo: MACRO (sstsimulator/sst-macro)

Pull Request Author: leekillough

leekillough · 2025-04-17T19:42:54Z

@gvoskuilen

sst-autotester · 2025-04-17T20:19:21Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Num: 1972
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Num: 1928
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Num: 1927
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Num: 875
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Num: 727
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Num: 681
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Num: 494
Status: PASSED

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Build Num: 300
Status: PASSED

sst-autotester · 2025-04-17T20:19:39Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ gvoskuilen ]!

sst-autotester · 2025-04-17T20:19:46Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) AT: CLANG-FORMAT PASS AT: CMAKE-FORMAT PASS and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 16, 2025

feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 18, 2025

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 23, 2025

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Mar 23, 2025

feldergast added the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Mar 23, 2025

leekillough force-pushed the make_unique_vla branch from 130dd9b to a0d3090 Compare April 1, 2025 23:16

github-actions bot removed the AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) label Apr 1, 2025

leekillough force-pushed the make_unique_vla branch from a0d3090 to b2d7868 Compare April 6, 2025 04:52

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Apr 6, 2025

Replace variable-length arrays with std::make_unique allocated array…

7800d73

…s; add -Wvla

leekillough force-pushed the make_unique_vla branch from b2d7868 to 7800d73 Compare April 10, 2025 05:24

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Apr 10, 2025

Merge remote-tracking branch 'sstcore/devel' into make_unique_vla

ed344fb

github-actions bot added AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) and removed AT: WIP Mark PR as a Work in Progress (No Autotesting Performed) labels Apr 15, 2025

leekillough mentioned this pull request Apr 15, 2025

Change raw pointers to unique_ptr for static variables in new ELI #394

Closed

gvoskuilen added the AT: PRE-TEST INSPECTED label Apr 17, 2025

sst-autotester removed the AT: PRE-TEST INSPECTED label Apr 17, 2025

gvoskuilen self-requested a review April 17, 2025 19:48

gvoskuilen approved these changes Apr 17, 2025

View reviewed changes

feldergast merged commit 34d6c2f into sstsimulator:devel Apr 17, 2025
7 checks passed

leekillough mentioned this pull request Apr 28, 2025

Replace Variable Length Arrays with arrays allocated with std::make_unique sstsimulator/sst-elements#2512

Merged

leekillough deleted the make_unique_vla branch May 11, 2025 08:12

Use std::make_unique() for variable-length arrays instead of array[N] when N is not constant #1255

Use std::make_unique() for variable-length arrays instead of array[N] when N is not constant #1255

Uh oh!

Conversation

leekillough commented Mar 16, 2025

Uh oh!

github-actions bot commented Mar 16, 2025

Uh oh!

github-actions bot commented Mar 16, 2025

Uh oh!

sst-autotester commented Mar 16, 2025

Uh oh!

github-actions bot commented Mar 23, 2025

Uh oh!

github-actions bot commented Mar 23, 2025

Uh oh!

sst-autotester commented Mar 23, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

github-actions bot commented Apr 1, 2025

Uh oh!

sst-autotester commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 6, 2025

Uh oh!

sst-autotester commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 10, 2025

Uh oh!

github-actions bot commented Apr 10, 2025

Uh oh!

sst-autotester commented Apr 10, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

github-actions bot commented Apr 15, 2025

Uh oh!

sst-autotester commented Apr 15, 2025

Uh oh!

sst-autotester commented Apr 17, 2025

Uh oh!

sst-autotester commented Apr 17, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-macro_withsstcore

Using Repos:

Uh oh!

leekillough commented Apr 17, 2025

Uh oh!

sst-autotester commented Apr 17, 2025

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MR-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-elements_MT-2

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-macro_withsstcore

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_OMPI-4.1.4_PY3.6_sst-core_Make-Dist

Build Information

Test Name: SST__AutotestGen2_NewFW_sst-test_Clang-Format_sst-core

Build Information

Test Name: SST__AutotestGen2_NewFW_OSX-14-XC15-ARM2_OMPI-4.1.6_PY3.10_sst-elements