ci(release): drop redundant E2E from the orchestrate build path#461
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The orchestrate workflow calls the hand-written
build-cli.yamlreusable workflow, which had ane2e-testsjob running the full act+gitea e2e suite a second time on every release. That coverage is already enforced as the required PR gate (e2e.yaml, sharded, on pull_request/merge_group), so re-running it during the release path was redundant compute with no additional confidence.Fix
e2e-testsjob from.github/workflows/build-cli.yaml.jobs.e2e-tests.resulttojobs.build.result, sincebuildis now the only job.e2e.yaml), not here.build-cli.yamlis hand-written (no AUTO-GENERATED header) and is not touched by the generator.orchestrate.yaml(generated) still calls./.github/workflows/build-cli.yamlunchanged and readsneeds.build-cli.outputs.result, which now reflects the build job instead of the old e2e job.e2e.yaml(the PR gate) is untouched. The fleet still validates end-to-end behavior on live GitHub at the rc gate, independent of this path.Verification
go build ./...clean.cascade verify --config .github/manifest.yamlreports no drift (3 files, no drift) - confirms this hand-written change doesn't desync the generated workflows.grep -n e2e-tests .github/workflows/build-cli.yamlreturns nothing;grep -n jobs.build.result .github/workflows/build-cli.yamlmatches the new output line.docs/src/content/docs/workflows.md,coverage-matrix.md,architecture.md,getting-started.md,README.md): none claim the release/orchestrate path runs e2e, so no doc updates were needed.actionlinton the file reports a pre-existing false positive on theworkflow_calloutput expression (jobs.<id>.resultisn't recognized by its type checker in this shape); this was already present againstjobs.e2e-tests.resultbefore this change and is unrelated to it.