ci: skip Go cache save on Windows to stop flaky cache-save post-step#136
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
Disables the Go module/build cache on
windows-latestrunners across the matrix workflows (sink,source,test,release) by gating setup-go's cache:cache: ${{ runner.os != 'Windows' }}. Linux and macOS keep caching unchanged.Why
The
Post Run actions/setup-gocache-save step flakes intermittently onwindows-latest: thetar/zstdcache.tzstwrite fails and takes the whole job down with it even when the test step passed (seen on PR #132, sink unit). setup-go has no "restore-but-don't-save" option and a packaged action's post-step can't be made non-fatal, so gating the cache off on Windows is the deterministic fix. The cost is a cache miss on the Windows legs (a little slower, modules re-downloaded); the benefit is no more spurious red on green PRs.Relates to: the spurious failure on #132.
Checklist
git commit -s) per the DCOtype: subject)mage checkunaffected (workflow-only change)