feat: restart failed actors within a per-source budget#79
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
Restartsupervision decision: a failed actor is re-spawned through aRespawner(the node'sSystem, via a newRespawnprimitive that tears down the dead instance and spawns a fresh one under the same id), bounded by a per-src restart budget set withWithRestart. Each actor id may restart up to its src's limit; once the budget is spent the failure escalates instead, so a crash-looping actor cannot restart-storm. The respawner is wired withWithRespawnerorSetRespawner(the System is usually built after the Supervisor, so the setter is the ergonomic path). The supervisor records the decision it actually applied, so an exhausted-budget failure shows as an escalation. Backoff (timed restart) builds on this next. Coverage: cluster 99 percent. Additive; stdlib-only.