feat: add bounded symbolic guard reasoning to state/verify#89
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bounded symbolic guard reasoning over the kernel's Core
GuardNodetree, in a new stdlib-onlystate/verify/symbolicsub-package.Satisfiablereports whether a guard can ever hold,Contradictionwhether it is provably dead (unsatisfiable), andDisjointwhether two guards are provably mutually exclusive (the basis for competing-transition / nondeterminism detection). The analyzer normalizes a guard to disjunctive normal form (pushing negation via De Morgan) and checks each conjunctive clause for a per-field contradiction — numeric fields as intervals (bounds,ne-exclusion), discrete string/bool/enum fields as value sets (eq/ne/in). It is a pure-Go bounded analyzer, not an SMT solver and no CGo: it is deliberately conservative, so a Rich or named-leaf guard, a cross-field comparison, or a duration/time field is treated as an unconstrained unknown —ContradictionandDisjointare sound (a true verdict is always correct; unprovable cases are reported satisfiable / not-disjoint). It reads only the kernel's ownGuardNode/ContextSchema, adding no dependency. (Overlaps— the whole-machine competing-transition scan built onDisjoint— follows next.) Additive; stdlib-only.