feat: detect competing-transition overlaps via symbolic disjointness#90
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds nondeterminism detection on the symbolic disjointness primitive.
Overlapsscans a machine — descending into compound children and parallel regions — for competing transitions (same source state, same event) whose guards are not provably disjoint, returning each such pair. It is conservative: a pair is reported unless the analyzer can prove the guards mutually exclusive, so transitions guarded only by opaque (named Go-func or Rich) guards, or unguarded, are flagged as potential overlaps — a false positive is the safe direction for catching nondeterminism. An empty result means every same-source/same-event pair is provably disjoint over the analyzable Core guards. It reads the machine's IR (no registry/Provide needed) and a transition's effective guard is the conjunction of its named-ref guards and its composite GuardExpr. Tests cover disjoint guards (clean), overlapping numeric guards (reported), and opaque guards (conservatively reported). Additive; stdlib-only.