fix: prevent infinite recursion when expanding a self-initial parallel state#93
Merged
Merged
Conversation
…l state Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configGraph.descendinfinite-recursed when expanding a parallel state that also carries a self-referential initial-child marker — the shape produced bySuperState(X).Initial(X), which the food-delivery example uses for itsActivesuperstate. Any invariant check (MutualExclusion/Implies/NeverActive) or bounded simulation over such a machine would hang.Region initials are now consulted before the compound-initial marker (regions are authoritative for a parallel state), and the compound-initial branch is guarded against self-reference. Behavior is unchanged for every machine that previously terminated: the reordered branches differ only when a node has both region initials and a compound-initial marker, which arises solely for the degenerate self-initial parallel shape that previously looped.
Adds a regression test driving the self-initial parallel shape end to end through
MutualExclusion, plus a compound-state case covering the guarded descent.