Adds tests and fixes some async issues in transaction#37
Merged
itsjoeconway merged 2 commits intomasterfrom Apr 2, 2018
Merged
Adds tests and fixes some async issues in transaction#37itsjoeconway merged 2 commits intomasterfrom
itsjoeconway merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 91.18% 91.19% +<.01%
==========================================
Files 11 11
Lines 976 977 +1
==========================================
+ Hits 890 891 +1
Misses 86 86
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where a transaction closure would continue executing when a query throws. Subsequent queries were not run, but that the code ran could still lead to other bugs.
Ensure that transactions are tore down correctly if an unawaited query throws.