Skip to content

refactor query caching into a separate object to reduce code in Query…#39

Merged
itsjoeconway merged 2 commits intomasterfrom
jc/query-cache
Apr 3, 2018
Merged

refactor query caching into a separate object to reduce code in Query…#39
itsjoeconway merged 2 commits intomasterfrom
jc/query-cache

Conversation

@itsjoeconway
Copy link
Contributor

… object.

This is the first part of a refactor to unify the execution context/connection interface to avoid duplicate code paths.

@codecov-io
Copy link

codecov-io commented Apr 3, 2018

Codecov Report

Merging #39 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   91.19%   91.18%   -0.01%     
==========================================
  Files          11       12       +1     
  Lines         977      976       -1     
==========================================
- Hits          891      890       -1     
  Misses         86       86
Impacted Files Coverage Δ
lib/src/transaction_proxy.dart 90.47% <100%> (ø) ⬆️
lib/src/query.dart 96% <100%> (ø) ⬆️
lib/src/query_cache.dart 100% <100%> (ø)
lib/src/connection_fsm.dart 86.86% <100%> (ø) ⬆️
lib/src/connection.dart 91.12% <100%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f542f1...aced3ba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants