Allow raster bands in Collection's item assets#16
Merged
emmanuelmathot merged 1 commit intostac-extensions:mainfrom Jun 30, 2021
Merged
Conversation
emmanuelmathot
requested changes
Jun 2, 2021
Member
emmanuelmathot
left a comment
There was a problem hiding this comment.
LGTM. Do you have an example to put in the repo?
Contributor
Author
|
I don't have an example off hand. I could take one of the existing planet or sentinel item examples and convert it to a collection, moving |
m-mohr
approved these changes
Jun 30, 2021
Contributor
m-mohr
left a comment
There was a problem hiding this comment.
Looks good to me.
I don't think we necessarily need an example, most other extensions also don't have one at hand. It's the normal behavior in STAC anyway and there's nothing specific in raster.
emmanuelmathot
approved these changes
Jun 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the JSON Schema to allow raster band information in a Collection's
item_assetskey. This is identical to what the EO extension does: https://github.com/stac-extensions/eo/blob/89da8dc305f43cf34980b3d52f3bfbbc4d8c88d4/json-schema/schema.json#L85-L96