`get_collection` always returns last collection with a local catalog

[normanb]

I am opening a local static STAC catalog as follows

  client = Client.open(catalog)
  collection = client.get_collection(collection_name)

This always returns the last collection in the catalog.

I think this clause needs a break to get out of the iteration when the id matches the collection_id;

https://github.com/stac-utils/pystac-client/blob/main/pystac_client/client.py#L412

[jsignell]

Oh! Yeah that makes sense.

[jsignell]

Also if you are using a static catalog it might be easier to just use pystac directly although they interface is slightly different. Something like:

import pystac

catalog = pystac.Catalog.from_file(catalog)
collection = next(c for c in client.get_collections() if c.id == collection.id)