Remove troublesome assertion #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of things going on here: - Without stac-utils/pystac#1171, the resolved collection won't have a root. - Even with stac-utils/pystac#1171, the root will be cast to a `Catalog` by https://github.com/stac-utils/pystac/blob/9b363db07f19692d319804ccffce23b72d759839/pystac/stac_object.py#L275-L292, so this assertion would fail even with the preserve_dict To fix breakages to existing code, we remove the assertion, and assume that stuff will blow up later if the `root` isn't the correct object type.
gadomski
force-pushed
the
issues/548-stac-object-from-dict
branch
from
d4cfd76 to
b8168d8
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 88.04% 88.02% -0.02%
==========================================
Files 13 13
Lines 995 994 -1
==========================================
- Hits 876 875 -1
Misses 119 119
☔ View full report in Codecov by Sentry. |
TomAugspurger
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
AssertionErrorinstac_object_from_dictwhen callingitem.get_collection()in 0.7.1 #548Description:
Couple of things going on here:
Catalogby https://github.com/stac-utils/pystac/blob/9b363db07f19692d319804ccffce23b72d759839/pystac/stac_object.py#L275-L292, so this assertion would fail even with the PR mergeTo fix breakages to existing code, we remove the assertion, and assume that stuff will blow up later if the
rootisn't the correct object type.PR Checklist: